Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): limit yarn@^1.0.0 #3357

Merged
merged 1 commit into from
Nov 3, 2023
Merged

chore(cli): limit yarn@^1.0.0 #3357

merged 1 commit into from
Nov 3, 2023

Conversation

erickzhao
Copy link
Member

Explicitly disallows Yarn 2 and drops support for Yarn 0.x.

This is technically a breaking change, but according to npm's download stats, Yarn 0.x only has 2000 installs (~0.08%) of yarn (<=1.x) installs in the last week.

@erickzhao erickzhao requested a review from a team as a code owner September 18, 2023 18:26
@erickzhao erickzhao changed the title chore(cli): limit yarn@&1.0.0 chore(cli): limit yarn@^1.0.0 Sep 18, 2023
@mahnunchik
Copy link
Contributor

@erickzhao could you please assist how to install deps and build the project? Current yarn produces 1+ changes in the sources on install command.

I'd like to rebase and move forward the changes I need for the production project:

@mahnunchik
Copy link
Contributor

What is the purpose to use yarn instead of npm?

@erickzhao
Copy link
Member Author

could you please assist how to install deps and build the project? Current yarn produces 1+ changes in the sources on install command.

Which yarn version are you using? I ran a clean install on my machine this week and there are no changes on install for me.

@mahnunchik
Copy link
Contributor

I used system version after corepack enable. It was 3.2.4 and it produces 1K+ changes in the sources.

After I've switched to 1.22.19 via yarn set version 1.22.19 but there are still changes: new .yarnrc.yml file, .yarn folder and field in package.json.

I was able to figure out that changes and not submit with PR.

@erickzhao erickzhao mentioned this pull request Sep 20, 2023
Merged
@erickzhao
Copy link
Member Author

This would fix it but I'm not sure what other maintainers think about the corepack thing: #3359

@erickzhao erickzhao requested a review from a team November 3, 2023 21:42
@erickzhao erickzhao merged commit fd00d9a into main Nov 3, 2023
3 checks passed
@erickzhao erickzhao deleted the yarn-1 branch November 3, 2023 23:50
@adidahiya
Copy link

Why is Yarn v4.x disallowed? It was working fine for me with the classic nodeLinker: node-modules install mode with electron-forge v6.x.

@adidahiya adidahiya mentioned this pull request Nov 16, 2023
Merged
@erickzhao
Copy link
Member Author

erickzhao commented Nov 17, 2023 •
edited
Loading

reversing course here @adidahiya #3411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erickzhao @mahnunchik @adidahiya @malept